-
-
Notifications
You must be signed in to change notification settings - Fork 506
Preview image in the full size of Room component when clicking messages with image files. #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preview image in the full size of Room component when clicking messages with image files. #246
Conversation
I think after adding the preview, you can add functions such as the previous picture and the next picture, and even enhance the interface, such as zooming in and out, rotating left and right, just like elementui.https://element.eleme.cn/#/zh-CN/component/image#da-tu-yu-lan Of course, if you are inconvenient, I can also help after the authors merge |
Thanks for the PR! |
…preview: true/false
I had added prop to disable this behavior and change some variable name for more readable. I am not sure if I need to resolve the conflicts before I commit again. |
This feature sounds great and I think it is not complex. I will see if I have time for doing this after author merge. |
Yes please resolve the conflicts otherwise I won’t be able to merge this PR |
I tested the branch locally, it works fine and the idea is good, but the UI is not very beautiful. I'll improve it a bit before we can merge this. |
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
